chore: migrate ci from travis to github actions #658
Conversation
|
good job! |
|
I think we could run build and tests for every pull request, instead of adding a "ready-for-testing" label manually for the PR needed to test. |
It's for the security of our self-hosted runner. Without such restriction, anyone can submit a pull-request that will possibly attack the server. And of course, it saves the resource as well. |
neverchanje
added
the
ready-for-testing
I agree with @zhangyifan27 , and seems we can limit parallel jobs, https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-syntax-for-github-actions#jobs |
@acelyc111 |
neverchanje
removed
the
ready-for-testing
|
@acelyc111 OK, now I removed ready-for-testing requirement for PR. Please take a look. |
LGTM |
This PR configures the github action jobs of when a pull-request created. I've written a wiki here: https://cwiki.apache.org/confluence/display/PEGASUS/Github+Actions.
In addition, since the former formatting script
./scripts/linux/run-clang-format.shrelies on git to compare if codes changed, which is unavailable on github actions, I introduce a new filerun-clang-format.pycopied directly from https://github.com/Sarcasm/run-clang-format.As travis-ci is no longer used,
.travis.ymlis removed now.Test
load_from_private_log_test.restart_duplication2is removed because the case fails on CI. And I found it impossible to happen. Because learner always replaces the original log dir if it learns from primary's private log.